[RuntimeDyld][Windows] Allocate space for dllimport things. #9071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We weren't taking account of the space we require in the stubs for things that are `dllimport`ed, and as a result we could hit the assertion failure for running out of stub space. Fix that. rdar://133473673
|
@swift-ci Please test |
|
This is going to need cherry picking to |
compnerd
approved these changes
Aug 8, 2024
|
Would also be nice to pull this into release/6.0 as it should be very low risk and enables better parity. |
|
@swift-ci Please test |
|
@swift-ci Please test macOS platform |
|
@swift-ci Please test Windows platform |
|
(The macOS failure was some spurious Jenkins problem.) |
This was referenced Aug 9, 2024
No need for `TargetName` to exist separately, really. Co-authored-by: Saleem Abdulrasool <[email protected]>
al45tair
force-pushed
the
eng/PR-133473673
branch
from
8b7b752 to
43d7520
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't taking account of the space we require in the stubs for things that are
dllimported, and as a result we could hit the assertion failure for running out of stub space. Fix that.rdar://133473673